I'm learning AngularJS and as an exercise trying to write an ascending sort filter:
This is my html file:
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title></title>
<script src="../Scripts/angular.min.js"></script>
<script src="../Scripts/Controllers/app.js"></script>
</head>
<body ng-app="myApp">
<ul ng-init="names = ['Peter','Anton','John']">
<li ng-repeat="name in names | sortAscending ">
<span>{{name}}</span>
</li>
</ul>
</body>
</html>
This is my filter:
app.filter("sortAscending", function () {
return function (input) {
var result = [];
for (var i = 0; i < input.length; i++) {
if (input[i] > input[i + 1]) {
result.push(input[i]);
}
}
return result;
}
});
I thing something is wrong in the loop regarding comparing the values.
What am I doing wrong?
Three things:
Your filter didn't return anything (missing return statement)
The ng-init should only be used for aliases, it is not a good practice to declare variables in it. In your example, you should use the ng-init to apply your filter to your array, but the array itself should be declared in the controller.
Your sorting algorithm is not working. To sort a simple array like that you can simply use the javascript sort() method.
Here is a working plunker with the three points corrected:
http://plnkr.co/edit/Qv9TDonFmpJsnIjx3dff?p=preview
Edit: I guess you wanted to understand this as a form of exercise, so my solution addresses only the way you tried to solve the issue. Like other mentionned, it's true that you could use the orderby filter to make this easier in the end.