I'm having problems reading a serializaed object back from its stored file. (See code below).
The serialization process "works", (albeit, probably written very poorly), and because there is no way of knowing whether the user is passing a std::ios::binary flag or not I opted NOT to use formatted output with whitespace
. (It also saves on memory as the potential for massive amounts of pixel data was not lost on me.)
My first attempt looked the same as the sample but the int
s were unsigned char
s with the intent of bit-packing the lower and upper halves into char
s and later reassembling them.
Currently I can read all data to a file but when I attempt to read the first piece of non-checksum data it either returned 0 (in the case of the attempt with the char
s) or garbage (in the case of the attempt with the int
s)
Serialization:
std::ostream& operator<<(std::ostream& os, const Sprite& data) {
int dF = data._dimensions.first;
int dS = data._dimensions.second;
int cF = data._center.first;
int cS = data._center.second;
int fF = data._frameDimensions.first;
int fS = data._frameDimensions.second;
double sF = data._scaleDimensions.first;
double sS = data._scaleDimensions.second;
std::string name(*data._file);
name.shrink_to_fit();
os << 'S' << 'P' << 'R' << (name.length() + 1) << name.c_str() << dF << dS << cF << cS << fF << fS << sF << sS;
for(int x = 0; x < data._dimensions.first; ++x) {
for(int y = 0; y < data._dimensions.second; ++y) {
int color = getpixel(data._image, x, y);
os << static_cast<unsigned char>(getr(color)) << static_cast<unsigned char>(getg(color)) << static_cast<unsigned char>(getb(color));
}
}
int tint = data._tint;
os << static_cast<unsigned char>(getr(tint)) << static_cast<unsigned char>(getg(tint)) << static_cast<unsigned char>(getb(tint));
os << data._tintIntensity << data._alpha;
return os;
}
Deserialization:
std::istream& operator>>(std::istream& is, Sprite& data) {
char checksum[3];
is >> checksum[0] >> checksum[1] >> checksum[2];
if(checksum[0] != 'S' || checksum[1] != 'P' || checksum[2] != 'R') {
is.setstate(std::ios::failbit);
return is;
}
int name_length;
is >> name_length;
std::string name(name_length, '\0');
for(int i = 0; i <= name_length; ++i) {
char current_char = '\0';
is >> current_char;
name[i] = current_char;
}
int upper = 0;
int lower = 0;
is >> upper;
is >> lower;
data._dimensions.first = (upper << 8) | lower;
upper = 0;
lower = 0;
is >> upper >> lower;
data._dimensions.second = ((upper << 8) | lower);
upper = 0;
lower = 0;
is >> upper >> lower;
data._center.first = ((upper << 8) | lower);
upper = 0;
lower = 0;
is >> upper >> lower;
data._center.second = ((upper << 8) | lower);
upper = 0;
lower = 0;
is >> upper >> lower;
data._frameDimensions.first = ((upper << 8) | lower);
upper = 0;
lower = 0;
is >> upper >> lower;
data._frameDimensions.second = ((upper << 8) | lower);
double f = 0.0;
double s = 0.0;
is >> f >> s;
data._scaleDimensions.first = f;
data._scaleDimensions.second = s;
destroy_bitmap(data._image);
data._image = NULL;
data._image = create_bitmap(data._dimensions.first, data._dimensions.second);
for(int x = 0; x < data._dimensions.first; ++x) {
for(int y = 0; y < data._dimensions.second; ++y) {
unsigned char r = 0;
unsigned char g = 0;
unsigned char b = 0;
is >> r >> g >> b;
int color = ((r << 16) | (g << 8) | b); //0xRRGGBB
putpixel(data._image, x, y, color);
}
}
unsigned char rtint = 0;
unsigned char gtint = 0;
unsigned char btint = 0;
is >> rtint >> gtint >> btint;
data._tint = ((rtint << 16) | (gtint << 8) | btint); //0xRRGGBB
is >> data._tintIntensity;
is >> data._alpha;
return is;
}
shouldn't deserialization be something like this:
and similar for center, and frameDimensions