C# Windows Forms ping.SendAsync issues with DataGridView

Question

So I have this code below. I found a preview post and was working of it from here. But for some reason it is not cycling through and updating the cells with the reply status. It only updates the last ip in the list.

private static void ping_PingCompleted(object sender, PingCompletedEventArgs e)
{
    var reply = e.Reply;
    DataGridViewRow row = e.UserState as DataGridViewRow;
    DataGridViewCell PingStat = row.Cells["cPing"];
    if (!(reply == null))
    {
        switch (reply.Status)
        {
            case IPStatus.Success:
               PingStat.Value = string.Format("Reply from {0}: bytes={1} time={2}ms TTL={3}", reply.Address, reply.Buffer.Length, reply.RoundtripTime, reply.Options.Ttl);
               break;
            case IPStatus.TimedOut:
               PingStat.Value = "Connection has timed out...";
               break;
            default:
               PingStat.Value = string.Format("Ping failed: {0}", reply.Status.ToString());
               break;
        }
    }
}


private void bPing_Click(object sender, EventArgs e)
{
    String ip;
    Ping ping = new Ping();
    foreach (DataGridViewRow row in dgvData.Rows)
    {
        if(!row.IsNewRow)
        {
            ip = row.Cells["cIPAddress"].Value.ToString();

            ping.PingCompleted += new PingCompletedEventHandler(ping_PingCompleted);

            ping.SendAsync(ip, 1000, row);

            System.Threading.Thread.Sleep(5);
        }
    }
}

What am I doing incorrect? I thought with adding row to ping.SendAsync it would track all reply to corresponding ip/row?

UPDATED Code I am working with

        private static void ping_PingCompleted(object sender, PingCompletedEventArgs e)
    {
        var reply = e.Reply;
        DataGridViewRow row = e.UserState as DataGridViewRow;
        DataGridViewCell PingStat = row.Cells["cPing"];
        if (reply != null)
        {
            switch (reply.Status)
            {
                case IPStatus.Success:
                    PingStat.Value = string.Format("Reply from {0}: bytes={1} time={2}ms TTL={3}", reply.Address, reply.Buffer.Length, reply.RoundtripTime, reply.Options.Ttl);
                    break;
                case IPStatus.TimedOut:
                    PingStat.Value = "Connection has timed out...";
                    break;
                default:
                    PingStat.Value = string.Format("Ping failed: {0}", reply.Status.ToString());
                    break;
            }
        }
    }
    private void bPing_Click(object sender, EventArgs e)
    {
        foreach (DataGridViewRow row in dgvData.Rows)
        {
            if (!row.IsNewRow)
            {
                Debug.WriteLine("Rows");
                String ip;
                Ping ping = new Ping();
                ip = row.Cells["cIPAddress"].Value.ToString();
                ping.PingCompleted += new PingCompletedEventHandler(ping_PingCompleted);

                ping.SendAsync(ip, 1000, row);

                System.Threading.Thread.Sleep(5);
            }
        }
    }

Answer 1

I think the issue is that you have one Ping and one IP and these keep getting reset until the last row. If you move those vars into the foreach loop then each row in the DataGridView will have its "own" Ping and ip and so you will not have the issue of each row effectively undoing the previous.

private void bPing_Click(object sender, EventArgs e)
{
    foreach (DataGridViewRow row in dgvData.Rows)
    {
        if(!row.IsNewRow)
        {
            String ip;
            Ping ping = new Ping();
            ip = row.Cells["cIPAddress"].Value.ToString();
            ping.PingCompleted += new   PingCompletedEventHandler(ping_PingCompleted);

            ping.SendAsync(ip, 1000, row);

            System.Threading.Thread.Sleep(5);
        }
    }
}

Also, I am unfamiliar with "Ping", but you might want to see if it needs to be disposed of, or put it in a Using loop.

Also there is no need to cast a row to a row.

Answer 2

What about this:

private void bPing_Click(object sender, EventArgs e) {
    foreach (DataGridViewRow row in dgvData.Rows) {
        try {
            Ping pinger = new Ping();
            PingReply reply = await pinger.SendPingAsync(row.Cells["cIPAddress"].Value.ToString(),1000);
            switch (reply.Status) {
                // do your stuff here
            }
        } catch (PingException) {
            // Handle exception here
        }
    }
}