Can sombody enlighten to why two of lines in batch dont work

Question

Hi I have the following BAT file all works well except for lines 70 and 78 can anybody help

Tnx-

    @ECHO OFF

; Reseting system color configuration...
@COLOR 17

ECHO ===============================
ECHO == AUTOCAD 2010 De Mar Setup ==
ECHO ===============================
ECHO.

ECHO Creating a backup directory, Please wait...
ECHO.

mkdir C:\"AUTOCAD 2010 BACKUP"

ECHO.
ECHO AUTOCAD 2010 BACKUP directory successfully created...
ECHO.

ECHO Backing up nessesary files, Please wait...
ECHO.

xcopy /s/y C:\"Program Files\AutoCAD 2010\Support\acad2010doc.lsp" C:\"AUTOCAD 2010 BACKUP"
xcopy /s/y C:\"Program Files\AutoCAD 2010\Support\acad.lsp" C:\"AUTOCAD 2010 BACKUP"
xcopy /s/y C:\"Program Files\AutoCAD 2010\Support\acad.pgp" C:\"AUTOCAD 2010 BACKUP"

ECHO.
ECHO Nessesary files successfully Backed-up...
ECHO.

ECHO Deleting conflicting files, Please wait...
ECHO.

del C:\"Program Files\AutoCAD 2010\Support\acad2010doc.lsp"
del C:\"Program Files\AutoCAD 2010\Support\acad.lsp"
del C:\"Program Files\AutoCAD 2010\Support\acad.pgp"

ECHO.
ECHO Obsoleate files successfully deleted...
ECHO.

ECHO Deleting old desktop shortcut, Please wait...

del /s/q/f C:\"documents and settings\AutoCAD 2010.lnk"

ECHO.
ECHO Obsoleate desktop shortcut successfully deleted...
ECHO.

ECHO Refreshing Desktop icons...
ECHO.

rundll32 user32.dll,UpdatePerUserSystemParameters

ECHO.
ECHO Desktop successfully refreshed...
ECHO.

ECHO Creating Customised Shortcut, Please wait...
ECHO.

cscript "C:\VBS\SHORTCUT.vbs"

ECHO.
ECHO Customised shortcut successfully created...
ECHO.

ECHO Deleting AutoCAD 2010 Startup icon, Please wait...

ECHO Deleating obsoleate De Mar 2010 Setup uninstall startup icon...

del /s/q/f C:\"Documents and settings\%USERSPROFILE%\Menu Start\Programs\Hendrika's AutoCAD Instellingen\Uninstall Hendrika's AutoCAD Instellingen.lnk"

ECHO.
ECHO De Mar 2010 Setup uninstall startup icon successfully deleted...
ECHO.

ECHO Copying the UNINSTAAL DE MAR 2010.bat to new location...

xcopy /s/y/f C:\"BAT\UNINSTAAL DE MAR 2010.bat" C:\"Documents and Settings\%ALLUSERSPROFILE%\Menu Start\Programma's\Hendrika's AutoCAD Instellingen\"

MSG * AutoCAD 2010 Setup sucesfully compleated, Enjoy!

to recap the lines of concern are:

del /s/q/f C:\"Documents and settings\%USERSPROFILE%\Menu Start\Programs\Hendrika's AutoCAD Instellingen\Uninstall Hendrika's AutoCAD Instellingen.lnk"

and

    xcopy /s/y/f C:\"BAT\UNINSTAAL DE MAR 2010.bat" C:\"Documents and Settings\%ALLUSERSPROFILE%\Menu Start\Programma's\Hendrika's AutoCAD Instellingen\"

Answer 1

Probably the easiest thing to do is put an echo before both those lines, like:

echo del /s/q/f C:\"Docu ...

and put a:

pause

at the end so it waits for you to hit ENTER.

That should at least show you what the variable substitutions are doing within the script. I think what you may find is that %ALLUSERSPROFILE% is a full path name already and won't take kindly to being injected into the middle of another path:

C:\Documents and Settings\Pax\My Documents> echo %ALLUSERSPROFILE%
C:\Documents and Settings\All Users
C:\Documents and Settings\Pax\My Documents> echo %USERPROFILE%
C:\Documents and Settings\Pax

I think it's USERPROFILE by the way (singular), not the plural USERSPROFILE. At least that's how it is on my WinXP box.

I think you'll probably be able to fix it by using:

del /s/q/f "%USERSPROFILE%\Menu Start\Programs\Hendrika's AutoCAD Instellingen\Uninstall Hendrika's AutoCAD Instellingen.lnk"

and:

xcopy /s/y/f C:\"BAT\UNINSTAAL DE MAR 2010.bat" "%ALLUSERSPROFILE%\Menu Start\Programma's\Hendrika's AutoCAD Instellingen\"

Answer 2

Try executing the script in batch mode: cscript "C:\VBS\SHORTCUT.vbs" //B

It will suppress script errors and prompts however!

Answer 3

Go to a command prompt and type

echo %userprofile%

It will come back with "C:\Documents and Settings\YourProfileName"

You are trying to delete a non-existent directory..

del /s/q/f C:\"Documents and settings\C:\Documents and Settings\YourProfileName\Menu Start\Programs\Hendrika's AutoCAD Instellingen\Uninstall Hendrika's AutoCAD Instellingen.lnk"

%userprofile% all ready contains the "C:\Documents and Settings\Username" part of the path.

Same thing with %ALLUSERSPROFILE%.

      (You ARE typing USERprofile and not USER**S**profile, right? ;-)  )