check box unchecked issue when i scroll the custom listview android

Question

listview row having multiple checkboxex, when i checked the checkboxex then if i scroll the listview, its automatically unchecked the checkboxes. how can fix this issue. here is my getView method

        public View getView(final int position, View convertView, ViewGroup parent) {
            final QuestionRadioHolder questionRadioHolder;
            final QuestionCheckboxHolder questionCheckboxHolder;
            final Model rowItem = getItem(position);
            final int type = getItemViewType(position);

            if (type == TYPE1) {
                if (convertView == null) {
                    convertView = mInflater.inflate(R.layout.radio_layout, parent, false);
                    questionRadioHolder = new QuestionRadioHolder();
                    questionRadioHolder.txtQuestion = (TextView) convertView.findViewById(R.id.txtQue);
                    questionRadioHolder.rg = (RadioGroup) convertView.findViewById(R.id.rg);

                    Typeface face = Typeface.createFromAsset(getContext().getAssets(), "fonts/Raleway-SemiBold.ttf");
                    questionRadioHolder.txtQuestion.setTypeface(face);
                    convertView.setTag(questionRadioHolder);

                } else {
                    questionRadioHolder = (QuestionRadioHolder) convertView.getTag();
                }



                List<String> arrayList = rowItem.getArrayList();
                questionRadioHolder.txtQuestion.setText(rowItem.getQuestionText());
                questionRadioHolder.rg.removeAllViews();
                questionRadioHolder.rg.clearCheck();
                for (int i = 0; i < arrayList.size(); i++) {
                    RadioButton radioButton = new RadioButton(getContext());
                    radioButton.setId(i);
                    radioButton.setTextSize(12);
                    radioButton.setText(arrayList.get(i));
                    radioButton.setTypeface(face1);
                    questionRadioHolder.rg.addView(radioButton);
                }

//                questionRadioHolder.rg.removeAllViews();
                questionRadioHolder.rg.setOnCheckedChangeListener(new RadioGroup.OnCheckedChangeListener() {
                    public void onCheckedChanged(RadioGroup rg, int checkedId) {
                        for (int i = 0; i < rg.getChildCount(); i++) {
                            RadioButton btn = (RadioButton) rg.getChildAt(i);
                            ArrayList<String> list = new ArrayList<String>();
                            if (btn.getId() == checkedId) {
                                String text = btn.getText().toString();
                                int id = mList.get(position).getQuid();
                                System.out.println(position + "    position 2");
                                map.put(id, text);
                                list.add(0, text);
                                aMap1.put(id, list);
                                Log.d("radio", text);
                                Log.d("Queid:", "" + id);
                                return;
                            }
                        }
                    }
                });
            } else if (type == TYPE2) {
                if (convertView == null) {
                    convertView = mInflater.inflate(R.layout.checkbox_layout, parent, false);
                    questionCheckboxHolder = new QuestionCheckboxHolder();
                    questionCheckboxHolder.txtQuestionChk = (TextView) convertView.findViewById(R.id.chkQues);
                    questionCheckboxHolder.relativeLayout = (LinearLayout) convertView.findViewById(R.id.chkrl2);

                    Typeface face = Typeface.createFromAsset(getContext().getAssets(), "fonts/Raleway-SemiBold.ttf");
                    face1 = Typeface.createFromAsset(getContext().getAssets(), "fonts/Raleway-Regular.ttf");
                    questionCheckboxHolder.txtQuestionChk.setTypeface(face);

                    convertView.setTag(questionCheckboxHolder);
                } else {
                    questionCheckboxHolder = (QuestionCheckboxHolder) convertView.getTag();
                }


                List<String> arrayList = rowItem.getArrayList();
                questionCheckboxHolder.txtQuestionChk.setText(rowItem.getQuestionText());

                questionCheckboxHolder.relativeLayout.removeAllViews();

                for (int i = 0; i < arrayList.size(); i++) {
                    checkBox = new CheckBox(getContext());
                    checkBox.setId(i);
                    checkBox.setMinHeight(30);
                    checkBox.setMinimumWidth(30);
                    checkBox.setText(arrayList.get(i));
                    checkBox.setTypeface(face1);
                    checkBox.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
                        @Override
                        public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {

                            int position = (Integer) buttonView.getTag();


                            ArrayList<String> arraylist2 = new ArrayList<String>();
                            ArrayList<String> list = new ArrayList<String>();
                            int id = mList.get(position).getQuid();
                            arraylist2 = aMap1.get(id);
                            System.out.println(arraylist2);

                            if (arraylist2 == null) {
                                arraylist2 = list;
                            }
                            if (buttonView.isChecked()) {
                                arraylist2.add(buttonView.getText().toString());
                                aMap1.put(id, arraylist2);

                            } else {
                                arraylist2.remove(buttonView.getText().toString());
                                aMap1.put(id, arraylist2);
                            }
                            System.out.println(aMap1.get(id));

                        }
                    });




                    questionCheckboxHolder.relativeLayout.addView(checkBox);
                }
            }

            return convertView;
        }

If i scroll the listview, its automatically unchecked the checkbox, how can checked the checkbox.

Answer 1

Save your check list in ArrayList<Boolean>, and load it in getView():

ArrayList<Boolean> listCheck;

public YourAdapter(Context context, int resource, ArrayList<T> list) {
            super(context, resource, list);
    listCheck = new ArrayList<Boolean>;
    for (int i = 0; i < list.size(); i++) {
        listCheck.add(false); // init listCheck
    }
} 

public View getView(final int position, View convertView, ViewGroup parent) {
   yourCheckBox.setChecked(listCheck.get(position)); // set checkbox
   yourCheckBox.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
           @Override
      public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
           listCheck.set(position, isChecked); // update listChecked
      }
   }
}

Answer 2

Try this way this worked for me

public class CustomAdapter extends BaseAdapter {
    private final LayoutInflater inflater;
    private final Context context;
    private List<ModelCls> listData;

    public CustomAdapter(Context mainActivity, List<ModelCls> listData) {
        context = mainActivity;
        this.listData = listData;
        inflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
    }

    @Override
    public int getCount() {
        return listData.size();
    }

    @Override
    public Object getItem(int position) {
        return listData.get(position);
    }

    @Override
    public long getItemId(int position) {
        return 0;
    }

    @Override
    public View getView(final int position, View convertView, ViewGroup parent) {
        final ViewHolder holder;

        if (convertView == null) {
            holder = new ViewHolder();
            convertView = inflater.inflate(R.layout.list_item_poojaselection, null);
            holder.tv = (TextView) convertView.findViewById(R.id.list_item_poojaname);
            holder.checks = (CheckBox) convertView.findViewById(R.id.list_item_poojacheck);
            convertView.setTag(holder);
        }else {
            holder = (ViewHolder) convertView.getTag();
        }
        holder.checks.setOnCheckedChangeListener(null);
        holder.checks.setFocusable(false);

        if (listData.get(position).isselected) {
            holder.checks.setChecked(true);
        } else {
            holder.checks.setChecked(false);
        }

        holder.checks.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
            @Override
            public void onCheckedChanged(CompoundButton cb, boolean b) {

                if (checkMaxLimit()) {

                    if (listData.get(position).isselected && b) {
                        holder.checks.setChecked(false);
                        listData.get(position).isselected = false;

                    } else {
                        holder.checks.setChecked(false);
                        listData.get(position).isselected = false;
                        Toast.makeText(context, "Max limit reached", Toast.LENGTH_SHORT).show();
                    }
                } else {
                    if (b) {
                        listData.get(position).isselected = true;
                    } else {
                        listData.get(position).isselected = false;
                    }
                }
            }
        });

        holder.tv.setText(listData.get(position).getLISTING_NAME());
        return convertView;
    }

    public boolean checkMaxLimit() {
        int countermax = 0;
        for(ModelCls item : listData){
            if(item.isselected){
                countermax++;
            }
        }
        return countermax >= 5;
    }

    public class ViewHolder {
        TextView tv;
        public CheckBox checks;
    }
}

and if you want to recyclerview try this

http://android-pratap.blogspot.in/2015/01/recyclerview-with-checkbox-example.html

Answer 3

If you checked on checkbox, you can save it into a HashMap(key:position, value:true/false), and in method getView() you can distinguish which is checked or unchecked, then make the checkbox show its state.

Answer 4

Try Using a model class or array to keep the values of checkbox and update it on onclick if that checkbox may solve your issue I think.

 holder.checkBox.setChecked(mCheckList.get(position));
          holder.checkBox.setOnClickListener(new View.OnClickListener() {
          @Override
            public void onClick(View v) {
                mCheckList.set(position, !mCheckList.get(position));
                notifyDataSetChanged();
             }
          });