correct way to fire out a fail result in page reponse event listener in codeceptJS

Question

I wrote a helper methods to add a network response listener over Puppeteer page instance. the code looks like this

let Helper = codecept_helper;

class CheckHelper extends Helper {
  async listenRequest(listener)
  {
    const helper = this.helpers['Puppeteer'];
    await helper.page.setRequestInterception(true);
    helper.page.on("request",listener);
    return helper._waitForAction();
  }
  async listenResponse(listener)
  {
    const helper = this.helpers['Puppeteer'];
    helper.page.on("response",listener);
    return helper._waitForAction();
  }
}

module.exports = CheckHelper;

then in the test script

  let self=this;
  I.listenResponse((response)=>{
     if(response.url().match(/github.*\.js/) && response.headers()['content-length']>1000) {
         //codeceptjs.event.emit(codeceptjs.event.test.failed, self, 'js file is too big!');
         //codeceptjs.recorder.throw('js file is too big!')
         //codeceptjs.recorder.stop();
         //throw new Error('js file is too big!')
     }
  })
  I.amOnPage("https://www.github.com");

i first add response listener, then i goto "github", when some js file size is too big,i will throw out an error,in order too check content size is correctly.

however, even i throw error out (like the comments codes did), the main test flow just not stop, how do i do is the right way?

Answer 1

well,i found a solution later

i recorded all the page response into a custom object in the page instance. later i wrote a help methods to check whole records.

//in helper.js
startRecordResponse() {
    const helper = this.helpers['Puppeteer'];
    helper.page.on("response", (res) => {
        //record all response instance into savedResponse object inside page, we'll use it later
        helper.page.savedResponse = helper.page.savedResponse || {};
        helper.page.savedResponse[res.url()] = res;
    });
    return helper._waitForAction();
}

checkFileIsTooBig(filter, sizeLimit) {
    const helper = this.helpers['Puppeteer'];
    //use the data recorded in savedResponse object 
    Object.keys(helper.page.savedResponse).forEach((url) => {
        var res = helper.page.savedResponse[url];
        if (((filter instanceof RegExp && filter.test(url)) || (typeof filter == "string" && url.indexOf(filter) != -1)) && res.headers()['content-length'] > sizeLimit) {
            throw new Error(`file ${url} is too big,${res.headers()['content-length']} > ${sizeLimit}`)
        }
    })
    return helper._waitForAction();
}

then in test file

Before((I) => {
  I.startRecordResponse();
  I.amOnPage("https://www.github.com");
});

Scenario('github_test', (I) => {
        //check a js file contain github is less than 100 bytes
        I.checkFileIsTooBig(/github.*\.js/,100);
    }
);