Deface and a comment tag?

Question

trying to get rid of comment tag from HTML.ERB file with use of Deface library.

Any idea what would be the proper selector for the following

<!-- Get "Open Sans" font from Google --> ?

Tried to match with

Deface::Override.new(:virtual_path => 'spree/admin/shared/_head',
                     :name => 'remove-googleapis',
                     :remove => '!--')  # this thows an exception

Update (exception description):

Nokogiri::CSS::SyntaxError
unexpected '!' after ''

Answer 1

Deface uses Nokogiri, which uses CSS selectors (with jQuery extensions). At the time of writing, there is no way to select a comment node using these selectors. There are several questions on SO looking for ways to select comment tags using jQuery, and most of them point to the comments plugin. So there is probably no way to do it through the Deface gem.

If you really want to remove the comment nodes, you can look into using the sanitize gem, or using Nokogiri with xpath selectors.

From an engineering POV, it's probably not worth the effort. Why are you trying to remove a harmless comment tag anyway?