ERROR AsyncTask #1 while executing doInBackground And OutOfMemoryError

Question

I have an Error while load multiple image, the image successfully load, but it can't open twice. if i close the activity and reopen the activity i get the error

this is the error :

E/AndroidRuntime: FATAL EXCEPTION: AsyncTask #1
              java.lang.RuntimeException: An error occured while executing doInBackground()
                  at android.os.AsyncTask$3.done(AsyncTask.java:299)
                  at java.util.concurrent.FutureTask$Sync.innerSetException(FutureTask.java:273)
                  at java.util.concurrent.FutureTask.setException(FutureTask.java:124)
                  at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:307)
                  at java.util.concurrent.FutureTask.run(FutureTask.java:137)
                  at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:230)
                  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
                  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
                  at java.lang.Thread.run(Thread.java:856)
               Caused by: java.lang.OutOfMemoryError
                  at android.graphics.BitmapFactory.nativeDecodeStream(Native Method)
                  at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:527)
                  at com.metroapp.lazyloader.ImageLoader.decodeFile(ImageLoader.java:181)
                  at com.metroapp.lazyloader.ImageLoader.getBitmap(ImageLoader.java:78)
                  at com.metroapp.activity.CatalogsDetailActivity$GetImageAsyncTask.doInBackground(CatalogsDetailActivity.java:440)
                  at com.metroapp.activity.CatalogsDetailActivity$GetImageAsyncTask.doInBackground(CatalogsDetailActivity.java:429)
                  at android.os.AsyncTask$2.call(AsyncTask.java:287)
                  at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
                  at java.util.concurrent.FutureTask.run(FutureTask.java:137) 
                  at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:230) 
                  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076) 
                  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569) 
                  at java.lang.Thread.run(Thread.java:856) 

this is my code :

public class GetImageAsyncTask extends AsyncTask<Void, Void, String> {
    String bd_image;

    public GetImageAsyncTask(String bd_image) {
        this.bd_image=bd_image;
        load = new ImageLoader(ctx);
    }

    @Override
    protected String doInBackground(Void... params) {
        try {
            image = load.getBitmap(bd_image);
        } catch (Exception e) {
            e.printStackTrace();
        }
        return null;
    }

    @Override
    protected void onPostExecute(String s) {
        super.onPostExecute(s);
        arr.add(image);
        imageArray.remove(0);

        try {
            if (imageArray.size() > 0) {
                new GetImageAsyncTask(imageArray.get(0)).execute();
            }else{
                loadData();
            }
        }catch (Exception e){
            e.printStackTrace();
            loadData();
        }
    }
}

and

private Bitmap decodeFile(File f) {
    Bitmap bitmap = null;
    FileInputStream stream1= null;
    FileInputStream stream2= null;

    try {
        BitmapFactory.Options o = new BitmapFactory.Options();
        o.inJustDecodeBounds = true;
        stream1 = new FileInputStream(f);
        BitmapFactory.decodeStream(stream1, null, o);
        stream1.close();
    } catch (FileNotFoundException e) {
        e.printStackTrace();
    } catch (IOException e) {
        e.printStackTrace();
    }

    BitmapFactory.Options o2 = new BitmapFactory.Options();

    for (o2.inSampleSize = 1; o2.inSampleSize <= 32; o2.inSampleSize++) {
        try {
            stream2 = new FileInputStream(f);
            bitmap = BitmapFactory.decodeStream(stream2, null, o2);
            stream2.close();

            Log.d("DECODE FILE : ", "Decoded successfully for sampleSize " + o2.inSampleSize);
            break;
        } catch (OutOfMemoryError outOfMemoryError) {
            // If an OutOfMemoryError occurred, we continue with for loop and next inSampleSize value
            Log.e("DECODE FILE : ", "outOfMemoryError while reading file for sampleSize " + o2.inSampleSize + " retrying with higher value");
        } catch (FileNotFoundException e) {
            e.printStackTrace();
        } catch (IOException e) {
            e.printStackTrace();
        }
    }
    return bitmap;
}

any solution ?

Answer 1

Close your stream1 and stream2 in finally block and its Java guidelines. Also, in Android, make sure to recycle all Bitmap instances whenever not required.

Answer 2

private Bitmap loadBitmapEfficiently() {

// Get the dimensions of the View
int targetW = mImageView.getWidth();
int targetH = mImageView.getHeight();

// Get the dimensions of the bitmap
BitmapFactory.Options bmOptions = new BitmapFactory.Options();
bmOptions.inJustDecodeBounds = true;
BitmapFactory.decodeFile(mImagePath, bmOptions); // you can get imagePath from file
int photoW = bmOptions.outWidth;
int photoH = bmOptions.outHeight;

// Determine how much to scale down the image
int scaleFactor = Math.min(photoW/targetW, photoH/targetH);

// Decode the image file into a Bitmap sized to fill the View
bmOptions.inJustDecodeBounds = false;
bmOptions.inSampleSize = scaleFactor;
bmOptions.inPurgeable = true;

return BitmapFactory.decodeFile(mImagePath, bmOptions);

}

Answer 3

Do not try to increase heap size by android app using android:largeHeap="true" since it is not recommended.

I would personally recommend you to use Glide or Picasso library for image loading purpose. Since it not only handles cache issue inside but also is stable enough to be able to support all android versions.