How to grab data from one response from two possible API text responses in PHP?

Question

There's two possible responses of my API. I need to grab data from the received text response and need to store them as variables.

API Calling:

  $url="http://91.101.61.111:99/SendRequest/?mobile=9999999999&id=11011&reqref=501";
  $request_timeout = 60;
  $ch = curl_init();
  curl_setopt($ch, CURLOPT_URL, $url);
  curl_setopt($ch, CURLOPT_TIMEOUT, $request_timeout);
  curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, $request_timeout);
  curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
  $output = curl_exec($ch);
  $curl_error = curl_errno($ch);
  curl_close($ch); 

Possible API responses in plain text:

REQUEST ACCEPTED your ref=<myref> system_reference=<sysref>
Or,
REQUEST ERROR errorno=<error>;your ref=<myref>;system_reason=<sysreason>

In case of 1st possible response, I need to grab data like below:

$status = "REQUEST ACCEPTED";  
$myref = "501";  
$sysref = "BA01562";  

And in case of 2nd possible response, I need to grab data like below:

$status = "REQUEST ERROR";
$error = "25";
$myref = "501";
$sysreason = "Duplicate request";  

I have tried:

$response = preg_match('/([\w\s]+) ([\w]+)/', $output, $res);
$rstatus = $res[1];

if ($rstatus == "REQUEST ACCEPTED")
{
    $raccepted = preg_match('/([\w\s]+) your ref=([\d]+) system_reference=([\w]+)/', $output, $matches);
    $status = $matches[1];  
    $myref = $matches[2];  
    $sysref = $matches[3];  
}
elseif ($rstatus == "REQUEST ERROR")
{
    $rerror = preg_match('/([\w\s]+) errorno=([\d]+);your ref=([\d]+);system_reason=([\w\s]+)/', $output, $matches);
    $status = $matches[1];
    $error = $matches[2]; 
    $myref = $matches[3];  
    $sysreason = $matches[4];  
}

echo "Status is $status, My Ref ID is $myref";

Now, when I get the 1st possible response from API call, I always get the errors on the last line (echo ....), like below:

( ! ) Notice: Undefined variable: status
( ! ) Notice: Undefined variable: myref
Status is , My Ref ID is

But no issues when I receive the 2nd response. It shows as I want:

Status is REQUEST ERROR, My Ref ID is 501

Please help!

Answer 1

This is not the most efficient method, try using some proper format like JSON or something. Anyway, here is a solution:

$success = stristr($output, "REQUEST ACCEPTED");

if($success)
{
    $data = stristr($output, "ref");
    $raccepted = preg_match('/ref=([\d]+) system_reference=([\w]+)/', $data, $matches);
    var_dump($matches);
}
else
{
    $data = stristr($output, "errorno");
    $rerror = preg_match('/errorno=([\d]+);your ref=([\d]+);system_reason=([\w\s]+)/', $data, $matches);
    var_dump($matches);
}

Answer 2

You should change your regular expression

$response = preg_match('/([\w\s]+) ([\w]+)/', $output, $res); 

to

$response = preg_match('/\w+ \w+/is', $output, $res);

Test:

php > preg_match('/\w+ \w+/is', "REQUEST ACCEPTED your ref=some system_reference=some123", $res);
php > var_dump($res);
php shell code:1:
array(1) {
  [0] =>
  string(16) "REQUEST ACCEPTED"
}
php > preg_match('/\w+ \w+/is', "REQUEST ERROR errorno=123;your ref=SOMEref;system_reason=reason", $res);
php > var_dump($res);
php shell code:1:
array(1) {
  [0] =>
  string(13) "REQUEST ERROR"
}

Other recommendations:

1. Trim you response before test regular for using ^ and $ (begin and end of your regular part).
2. Use === instead == in this case
3. check exists $res[1]; before $rstatus = $res[1];