ListView only updates after orientation change

Question

I am attempting to enact the Parcelable pattern to save and restore my ListView data on orientation changes.

The problem is, the ListView will only update once I do an orientation change. It will not update otherwise. It used to work just fine, until I started implementing Parcelable.

All help is greatly appreciated!

My fragment class is copied below, but can also be accessed here on GitHub:

public class TrackActivityFragment extends Fragment {

private IconicAdapter trackResultListViewAdapter = null;
private String artistId = null;

private final String LOG_TAG = TrackActivityFragment.class.getSimpleName();

public TrackActivityFragment() {

}

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
                         Bundle savedInstanceState) {

    ArrayList<TrackParcelable> trackParcelables = null;

    View rootView = inflater.inflate(R.layout.fragment_track, container, false);

    Intent intent = getActivity().getIntent();

    if(intent != null && intent.hasExtra(Intent.EXTRA_SHORTCUT_NAME)) {
        artistId = intent.getStringExtra(Intent.EXTRA_SHORTCUT_NAME);
    }

    if(savedInstanceState == null || !savedInstanceState.containsKey("tracks_key")) {
        trackParcelables = new ArrayList<TrackParcelable>();
        performSearch(artistId);
    }
    else {
        trackParcelables = savedInstanceState.getParcelableArrayList("tracks_key");
    }

    ListView listView = (ListView) rootView.findViewById(R.id.listViewOfTopTracks);
    trackResultListViewAdapter = new IconicAdapter(trackParcelables,
            getTrackNamesFromParcelables(trackParcelables));
    listView.setAdapter(trackResultListViewAdapter);

    return rootView;
}

@Override
public void onResume() {
    super.onResume();
}

@Override
public void onSaveInstanceState(Bundle outState) {
    outState.putParcelableArrayList("tracks_key",
            trackResultListViewAdapter.getTrackParcelables());
    super.onSaveInstanceState(outState);
}

private ArrayList<String> getTrackNamesFromParcelables(ArrayList<TrackParcelable>
                                                               trackParcelables){

    ArrayList<String> trackNames = new ArrayList<>();
    for(TrackParcelable element : trackParcelables){
        trackNames.add(element.name);
    }
    return trackNames;
}



private void performSearch(String artistId) {
    SpotifyApi api = new SpotifyApi();
    SpotifyService spotify = api.getService();

    Map<String, Object> options = new HashMap<>();
    options.put("country", "US");
    spotify.getArtistTopTrack(artistId, options, new Callback<Tracks>() {
        @Override
        public void success(Tracks tracks, Response response) {
            final ArrayList<TrackParcelable> trackParcelables =
                    new ArrayList<TrackParcelable>();
            for (Track track : tracks.tracks) {
                trackParcelables.add(new TrackParcelable(track.name,track.album.name,
                        track.album.images.get(0).url,track.preview_url));
            }
            trackResultListViewAdapter.swapItems(trackParcelables);
            Log.d(LOG_TAG,trackParcelables.toString());

            getActivity().runOnUiThread(new Runnable() {
                @Override
                public void run() {
                    if(trackParcelables.size()==0){
                        Toast.makeText(getActivity(),
                                getString(R.string.no_tracks_found_toast),
                                Toast.LENGTH_SHORT).show();
                    }
                    trackResultListViewAdapter.notifyDataSetChanged();
                }
            });
        }

        @Override
        public void failure(RetrofitError error) {

        }
    });

}


//This ViewHolder Pattern is from Busy Android Coder's Guide page 274 of book version 6.7
class ViewHolder {
    ImageView icon=null;
    TextView trackName=null;
    TextView trackAlbum=null;
    ViewHolder(View row) {
        this.icon = (ImageView)row.findViewById(R.id.imageViewAlbum);
        this.trackName = (TextView)row.findViewById(R.id.textViewTrackTitle);
        this.trackAlbum = (TextView)row.findViewById(R.id.textViewTrackAlbum);
    }
}

//This IconicAdapter Pattern is from Busy Android Coder's Guide page 272 of book version 6.7
class IconicAdapter extends ArrayAdapter<String> {

    private ArrayList<TrackParcelable> trackParcelables;

    public IconicAdapter(ArrayList<TrackParcelable> trackParcelables,
                         ArrayList<String> trackNames) {
        super(getActivity(), R.layout.list_item_top_tracks, R.id.textViewTrackTitle
                , trackNames);
        this.trackParcelables = trackParcelables;
    }

    public void swapItems(ArrayList<TrackParcelable> trackParcelables) {
        this.trackParcelables = trackParcelables;
    }

    @Override
    public View getView(int position, View convertView, ViewGroup parent) {

        View row = super.getView(position, convertView, parent);
        ViewHolder holder = (ViewHolder)row.getTag();

        if (holder==null) {
            holder=new ViewHolder(row);
            row.setTag(holder);
        }

        Picasso.with(getActivity()).load(trackParcelables.get(position).albumImageUrl)
                .into(holder.icon);

        TextView trackAlbumTextView = (TextView)row.findViewById(R.id.textViewTrackAlbum);
        trackAlbumTextView.setText(trackParcelables.get(position).albumName);


        return row;

    }

    public ArrayList<TrackParcelable> getTrackParcelables(){
        return trackParcelables;
    }

}

Answer 1

The issue is that IconicAdapter is only tracking changes in trackNames, not in ArrayList <TrackParcelable> trackParcelables.

To fix this, I added a a member variable in my IconicAdapter for the trackNames and set this in the constructor like so:

    private ArrayList<TrackParcelable> trackParcelables;
    private ArrayList <String> trackNames;

    public IconicAdapter(ArrayList<TrackParcelable> trackParcelables,
                         ArrayList<String> trackNames) {
        super(getActivity(), R.layout.list_item_top_tracks, R.id.textViewTrackTitle
                , trackNames);
        this.trackNames = trackNames;
        this.trackParcelables = trackParcelables;
    }

Then, I edited my swapItems to update my ListView data like so:

 public void swapItems(ArrayList<TrackParcelable> trackParcelables) {
        this.trackParcelables = trackParcelables;
        trackNames.clear();
        trackNames.addAll(getTrackNamesFromParcelables(trackParcelables));
    }