NSOperationQueue Issue

Question

I have a code that i used as a image downloder in ios 6 but when i use same code in different application that used ios 5 it gives me error NSInvalidArgumentException', reason: '-[NSNull length]: unrecognized selector sent to instance hear is the code that i am using

[self.imageDownloadingQueue addOperationWithBlock:^{
            NSURL *imageUrl   = [NSURL URLWithString:ImageURL];
            NSData *imageData = [NSData dataWithContentsOfURL:imageUrl];
            UIImage *images    = nil;
            if (imageData)
                images = [UIImage imageWithData:imageData];
            if (images){
                [self.imageCache setObject:images forKey:ImageURL];
                [[NSOperationQueue mainQueue] addOperationWithBlock:^{
                    // make sure the cell is still visible
                    imageV.image = images;
                }];
            }
        }];

Can anybody tell me what i am doing wrong coz this code is help me a lot when downloading image separately. Thank you

PS Whole function that i am using

-(void) setScrollView:(UIScrollView *)scrollview :(NSArray *)contentArray{

    int x = 0;

    int i = 0;

    NSString *ImageURL=@"http://www.online-image-editor.com/styles/2013/images/example_image.png";



    for(NSDictionary *str in contentArray){

        UIImageView *imageV = [[UIImageView alloc ] initWithFrame:CGRectMake(x, 0, 200,125)];
        @try {
            ImageURL = [str objectForKey:@"image"];
       }
        @catch (NSException * e) {
            NSLog(@"Exception: %@", [e description]);
        }


        imageV.userInteractionEnabled = YES;

        ImageTapGesture *singleTap = [[ImageTapGesture alloc] initWithTarget:self action:@selector(tapDetectedMain:)];
        singleTap.newItem = str;
        singleTap.currentItem = i ;
        singleTap.numberOfTapsRequired = 1;

        [imageV addGestureRecognizer:singleTap];

       UILabel *title = [[UILabel alloc] initWithFrame:CGRectMake(x,125,200,20)];

        [title setFont:[UIFont systemFontOfSize:11]];
        title.numberOfLines = 2;
       title.autoresizingMask = UIViewAutoresizingFlexibleHeight;
       [title setBackgroundColor:[UIColor blackColor]];
       [title setTextColor:[UIColor whiteColor]];
       title.text = [NSString stringWithFormat:@" %@",[str objectForKey:@"title"]];


       x += title.frame.size.width+2;

        UIImage *cachedImage = [self.imageCache objectForKey:ImageURL];

       if (cachedImage){
           imageV.image = cachedImage;
        }
        else{
            imageV.image = [UIImage imageNamed:@"vdo.png"];

           [self.imageDownloadingQueue addOperationWithBlock:^{
               NSURL *imageUrl   = [NSURL URLWithString:ImageURL];
                NSData *imageData = [NSData dataWithContentsOfURL:imageUrl];
                UIImage *images    = nil;
                if (imageData)
                    images = [UIImage imageWithData:imageData];
                  if (images){
                      [self.imageCache setObject:images forKey:ImageURL];
                      [[NSOperationQueue mainQueue] addOperationWithBlock:^{
                        // make sure the cell is still visible
                        imageV.image = images;
                   }];
                }
            }];

        }

        [scrollview addSubview:imageV];
        [scrollview addSubview:title];
    }

    scrollview.contentSize = CGSizeMake(x, scrollview.frame.size.height);
    i++;

}

Answer 1

pls try this code:

[self.imageDownloadingQueue addOperationWithBlock:^{
    NSURL *imageUrl ;
    if((ImageURL!=nil)&&(![ImageURL isKindOfClass:[NSNull class]]))
    {
        imageUrl= [NSURL URLWithString:ImageURL];
    }
    NSData *imageData;
    if((imageUrl!=nil)&&(![imageUrl isKindOfClass:[NSNull class]]))
    {
        imageData = [NSData dataWithContentsOfURL:imageUrl];
    }

    UIImage *images    = nil;
    if((imageData!=nil)&&(![imageData isKindOfClass:[NSNull class]]))
        images = [UIImage imageWithData:imageData];
    if((images!=nil)&&(![images isKindOfClass:[NSNull class]]))
    {
        [self.imageCache setObject:images forKey:ImageURL];
        [[NSOperationQueue mainQueue] addOperationWithBlock:^{
            // make sure the cell is still visible
            imageV.image = images;
        }];
    }
}];

Hope this will help you.

Answer 2

You should definitely check the ImageURL you are sending into the operation. It seems, this ImageURL is [NSNull null]. If it is a local variable, is it declared as __block NSString *ImageUrl?