Slow interation over a ReadWriteLock protected map: read lock, concurrent map or copying?

Question

I have a map that is frequently read but rarely write to. Some operations (can be reading or writing) involves multiple objects that needs to be operated atomically, so I used a ReadWriteLock to improve performance.

Now I have the option to downgrade the concurrent map to a normal hash map, but I am concerned about some of the slow iteration code.

If I downgrade the map, the long iterators to must hold the read lock to avoid concurrent access exceptions. I think this will block the writing threads for too long.

Since some of the iterators are not sensitive to inconsistent data, I can keep the concurrent map so that iterators can be used with concurrent writes. However, this adds unnecessary overhead (from the concurrent map) to operations that are properly using the locks.

Alternatively, I can implement something like a Read-on-write map, where the entire (non-concurrent) map is cloned for a write operation so that existing iterators continues to work outside a read lock.

Obviously, all these methods are valid and the performance depends on the actual code and setup. However, I am wondering is there any study on this (so I don't have to do the experiments myself)?

Answer 1

I have a map that is frequently read but rarely write to.

In that case I would consider implementing a copy of write map. e.g.

private final Map<Key, Value> map = ?* thread safe map */
private volatile Map<Key, Value> mapCopy = emptyMap();

// when you write
get lock
modify map
take a copy and store it in mapCopy
release lock

// when you read
Map<Key, Value> map = this.mapCopy;
use map

As you can see, you never need to obtain a lock on a read, only on a write.

If I downgrade the map, the long iterators to must hold the read lock to avoid concurrent access exceptions. I think this will block the writing threads for too long.

Instead of guess, I suggest you measure it.

I am wondering is there any study on this

I wouldn't take such a study too seriously if it did. As you suggest the result vary based on your situation.