Working directory filesharing

Question

This is my first post. I just take a update to write what i did

import java.io.*;
import java.rmi.*;
import javax.swing.JOptionPane;
public class FileClient{
public static void main(String a[]) {

    Object[] choice = {"download", "upload"};
    int valg = JOptionPane.showOptionDialog(null, "What do u want to do?", null, JOptionPane.YES_NO_OPTION, JOptionPane.PLAIN_MESSAGE, null, options, "");
    switch(choice){
        case 0:
        try {
        String filename = JOptionPane.showInputDialog("what do u want to copy? ");
        String name = "rmi://" + "localhost" + "/FileServer";
        FileInterface fi = (FileInterface) Naming.lookup(name);
        byte[] filedata = fi.downloadFile(ServerDirectory + filnavn);
        File file = new File(filnavn);
        BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(file.getName()));
        output.write(filedata,0,filedata.length);
        output.flush();
        output.close();
        System.out.println(file.getAbsolutePath());

    } catch(Exception e) {
        System.err.println("FileServer exception: "+ e.getMessage());
        e.printStackTrace();
    }
                    break;
                case 1:

                    break;
    }
}
}

The problem i have is that i cant choose the working directory in the code.

So what i learned was that u cant choose the Working Directory folder in java so i just put in paths so where i get the files and where i want to download them:

String PathToDownloadFolder = ("//C:/Hello/")
String PathToWhereIGetTheFile = ("//C:/server/")
byte[] filedata = cf.downloadFile(PathToWhereIGetTheFile + valgtFil);
BufferedOutputStream output = new BufferedOutputStream
                    (new FileOutputStream(PathToDownloadFolder + file.getName()));

Answer 1

You construct an absolute path with

File file = new File(ClientDirectory + fileName);

But then you still use the file name when constructing the stream:

BufferedInputStream input = new BufferedInputStream(new FileInputStream(fileName));

Replace this line with

BufferedInputStream input = new BufferedInputStream(new FileInputStream(file));

And it should be better.

That said, you should read the Java IO tutorial, because you don't use files and streams correctly. For example, you don't read all the bytes of your file, and you don't close streams in finally blocks.