Msbuild warning does not break the build

Question

After execute MSbuild task (under TFS2017) with the following parameters:

/m /property:StyleCopTreatErrorsAsWarnings=false /property:StyleCopEnabled=true /p:SkipInvalidConfigurations=true

the compilation succeed. The warning is shown under Summary / build but my expectation is that the compilation would have to finish with error.

The warning is:

Warning : CA1822 : Microsoft.Performance : The 'this' parameter (or 'Me' in Visual Basic) of ...

Are the MsBuild parameters set incorrectly?

Answer 1

By default all rules for code analysis - warnings. You have to set for critical rules an error property:

1. Select code analysis:

2. Update the rule properties:

3. That`ll generate a new ruleset file to your project

4. You get a failed build

Also you may create any custom ruleset and use it for your builds: How do I specify a ruleset from MSBuild