Reallocation of dynamic 2 dimensional array with double Pointers to structs and struct Pointer

Question

I asked a question aboult allocation and reallocation of a dynamic Pointer within a struct. But now I have within a struct a doublepointer component.

I want to reallocate the adjacency Matrix of a graph after adding vertices.

The reallocation of the doublepointer works, but when I want to reallocate the pointers (which the doublepointer is pointing to) in a loop, the programm stops in the first loop run with a segmentation fault...

This is my idea (drawn in paint...) myIdea

For better readability I divided my code

Here is the code Part 1:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <math.h>

struct Vertices
{
    int id;
    char name[15];
    float xPos;
    float yPos;
};

struct Edge
{
    int id;
    struct Vertices *start;
    struct Vertices *end;
};


struct Graph
{
    int VertexCounter;
    struct Vertices *vertex;
    struct Edge **adjMat;
};

Part 2 with the reallocation problem in updateAdjMat ():

//Initializing graph
void initGraph(struct Graph **graph)
{
    *graph = calloc (1, sizeof(struct Graph **));
    if (!*graph) {
        perror ("calloc-*graph");
        exit (EXIT_FAILURE);
    }

    (*graph)->vertex = NULL;
    (*graph)->adjMat = NULL;
    /*
    (*graph)->adjMat = calloc (1, sizeof (struct Edge **));
    if (!(*graph)->adjMat) {
        perror ("calloc-(*graph)->adjMat");
        exit (EXIT_FAILURE);
    }
    */

    (*graph)->VertexCounter = 0;
}


void updateAdjMat (struct Graph *graph)
{
    int i;

    void *tmp = realloc (graph->adjMat, graph->VertexCounter * sizeof (struct Edge *));
    if (!tmp) 
    {
        perror ("realloc-graph->adjMat");
        exit (EXIT_FAILURE);
    }

    graph->adjMat = tmp;

    for (i = 0; i < graph->VertexCounter; i++)
    {
        void *tmp = realloc (*(graph->adjMat + i), (graph->VertexCounter) * sizeof (struct Edge));
        if(!tmp)
        {
            perror ("realloc-*(graph->adjMat + i)");
            exit (EXIT_FAILURE);
        }
        *(graph->adjMat + i) = tmp;
    }

}

Part 3 with working code:

//reallocating the memory for the vertex pointer
void addVertex (struct Graph *graph, char name[15], float x, float y)
{
    void *tmp = realloc (graph->vertex, (graph->VertexCounter + 1) * sizeof(*graph->vertex));
    if (!tmp) {
        perror ("realloc-(*graph)->vertex");
        exit (EXIT_FAILURE);
    }
    graph->vertex = tmp;

    (graph->vertex + graph->VertexCounter)->id = graph->VertexCounter + 1;
    strcpy((graph->vertex + graph->VertexCounter)->name, name);
    (graph->vertex + graph->VertexCounter)->xPos = x;
    (graph->vertex + graph->VertexCounter)->yPos = y;

    graph->VertexCounter++;

    updateAdjMat(graph);
}

void menu_addVertex (struct Graph *graph)
{
    char name[15];
    float xPos, yPos;

    printf ("\nWhats the name of the vertex?\n");
    scanf ("%s", &name);
    printf ("\nX Coordinate?\n");
    scanf ("%f", &xPos);
    printf ("\nY Coordinate?\n");
    scanf ("%f", &yPos);
    printf ("\n");

    addVertex (graph, name, xPos, yPos);
}

//free the allocated memory
void freeGraph (struct Graph *graph)
{
    free (*(graph->adjMat));
    free (graph->adjMat);
    free (graph->vertex);
    free (graph);
}

In my Main I just have a menu to add new vertices with a name and x, y coordinates by calling addVertex

Answer 1

Your graph initialization is wrong.

Firstly, you are passing in a Graph ** so that you can assign a value of Graph * to it. But then inside you are allocated a Graph **, not a Graph *. It just so happens that pointers are generally the same size, so it will turn out OK, but the code is wrong.

*graph = calloc (1, sizeof(struct Graph **));

You actually want to be allocating a Graph *.

Even then, afterwards, you have not allocated a Graph. All you have allocated is a pointer!

So here you have code that is following two pointers, first with *graph and then with ->

(*graph)->VertexCounter = 0;

This would normally give you access to the Graph, but you have not allocated a Graph, you have only allocate a pointer to a graph. So this could very well crash at this point. Anything that follows might crash.

Answer 2

I found the solution. The problem was, that the memory I wanted to reallocate in the for loop wasn't initialized.

With that for loop it started to work:

    for (i = 0; i < graph->VertexCounter; i++)
    {
        //if the new column wasn't initialized
        if (i + 1 == graph->VertexCounter) {
            *(graph->adjMat + i) = calloc(graph->VertexCounter, sizeof **graph->adjMat);
        }
        else {
            void *tmp = realloc (*(graph->adjMat + i), graph->VertexCounter * sizeof (**graph->adjMat));
            if(!tmp)
            {
                perror ("realloc-*(graph->adjMat + i)");
                exit (EXIT_FAILURE);
            }
            *(graph->adjMat + i) = tmp;
        }

        for (j = 0; j < graph->VertexCounter; j++)
        {
            if (i + 1 == graph->VertexCounter || j + 1 == graph->VertexCounter)
            {
                //Doing some initialization to the new edges
            }

        }
    }