I'm use to using Crucible on code reviews, but we started using Github pull-request. I've created a pull-request and now completed the changes suggested by one of the code reviewers. What I did was I committed the changes on the same branch but when I went to github, the commits were separated. In Crucible you can view all the commits in one view. There is an option to merge commits but I'm not sure which one is the correct option. Basically, I just want to update the pull request with the latest change and reviewers will be able to see what was change from previous commits. Not sure if I merge/rebase it and changes will not be viewable anymore
What is Crucible's "Add Latest" equivalent in GitHub?
88 Views Asked by Reydan Gatchalian At
1
There are 1 best solutions below
Related Questions in GITHUB
- How to get max of subseries in Pine script
- Tradingview Indicator from pine script v 2 to version 4
- How to make a variable true or false in the "if" function in pine editor?
- Plotting SMA and MA of RSI together
- How can i get the value of previous highest high in pinescript?
- Pine script Cannot call 'security' with arguments
- How to find the closest value in pinescript array?
- PineScript - How to compare a higher high to current price
- Exit from position in exact time
- How to calculate Heiken Chaiken Osc using pandas python
Related Questions in PULL-REQUEST
- How to get max of subseries in Pine script
- Tradingview Indicator from pine script v 2 to version 4
- How to make a variable true or false in the "if" function in pine editor?
- Plotting SMA and MA of RSI together
- How can i get the value of previous highest high in pinescript?
- Pine script Cannot call 'security' with arguments
- How to find the closest value in pinescript array?
- PineScript - How to compare a higher high to current price
- Exit from position in exact time
- How to calculate Heiken Chaiken Osc using pandas python
Related Questions in GITHUB-CODEREVIEWS
- How to get max of subseries in Pine script
- Tradingview Indicator from pine script v 2 to version 4
- How to make a variable true or false in the "if" function in pine editor?
- Plotting SMA and MA of RSI together
- How can i get the value of previous highest high in pinescript?
- Pine script Cannot call 'security' with arguments
- How to find the closest value in pinescript array?
- PineScript - How to compare a higher high to current price
- Exit from position in exact time
- How to calculate Heiken Chaiken Osc using pandas python
Trending Questions
- UIImageView Frame Doesn't Reflect Constraints
- Is it possible to use adb commands to click on a view by finding its ID?
- How to create a new web character symbol recognizable by html/javascript?
- Why isn't my CSS3 animation smooth in Google Chrome (but very smooth on other browsers)?
- Heap Gives Page Fault
- Connect ffmpeg to Visual Studio 2008
- Both Object- and ValueAnimator jumps when Duration is set above API LvL 24
- How to avoid default initialization of objects in std::vector?
- second argument of the command line arguments in a format other than char** argv or char* argv[]
- How to improve efficiency of algorithm which generates next lexicographic permutation?
- Navigating to the another actvity app getting crash in android
- How to read the particular message format in android and store in sqlite database?
- Resetting inventory status after order is cancelled
- Efficiently compute powers of X in SSE/AVX
- Insert into an external database using ajax and php : POST 500 (Internal Server Error)
Popular # Hahtags
Popular Questions
- How do I undo the most recent local commits in Git?
- How can I remove a specific item from an array in JavaScript?
- How do I delete a Git branch locally and remotely?
- Find all files containing a specific text (string) on Linux?
- How do I revert a Git repository to a previous commit?
- How do I create an HTML button that acts like a link?
- How do I check out a remote Git branch?
- How do I force "git pull" to overwrite local files?
- How do I list all files of a directory?
- How to check whether a string contains a substring in JavaScript?
- How do I redirect to another webpage?
- How can I iterate over rows in a Pandas DataFrame?
- How do I convert a String to an int in Java?
- Does Python have a string 'contains' substring method?
- How do I check if a string contains a specific word?
This is expected, since you have made a first commit (before you received comments from your teammates), and a subsequent commit, meaning that you have two snapshots of your repository on that branch.
GitHub Pull Request is comparable to Crucible's Post-commit reviews.
The Merge pull request button shown in your screenshot should only be used once your reviewers and you have agreed that your changes are in good standing and that you want to merge your change into the target branch. It has nothing to do with "merging" your two commits together, which in Git terms is called squashing.
If you or your reviewers go to the Files changed tab, and select Changes from, you can see either
Take a look at the documentation About pull request reviews if you want to know more about it.