Java developers always use private access level for methods which are not used outside of this class. There are known benefits of doing so but from other side we increase complexity of unit tests. In most of cases our code is not used by any other services/APIs and we actually don't care of 'private' benefits. But what I believe we do care is to create readable simple unit tests. Considering this, why do not create all methods in class as 'package-private' by default and make them 'private' only in case when we really need this?
Why private access for methods is more preferable than package-private?
337 Views Asked by Aliaksei Yatsau At
1
There are 1 best solutions below
Related Questions in JAVA
- Embedding Microsoft Power BI into Liferay
- PowerBI hierarchy creation without the cloud
- How to create nested tiles in Power View
- BI Designer many to many relationship
- Microsoft Power BI Designer data model to Excel or PowerPivot
- How to link table row content to source in Power View
- Stream Analytic to PowerBI complains about PowerBIOutputAdapterTransientError
- How can I connect datasets from machine learning to SQL database in Azure?
- drilling from powerbi to ssrs
- How do you connect an Azure Table Storage with Power BI through Stream Analytics?
Related Questions in OOP
- Embedding Microsoft Power BI into Liferay
- PowerBI hierarchy creation without the cloud
- How to create nested tiles in Power View
- BI Designer many to many relationship
- Microsoft Power BI Designer data model to Excel or PowerPivot
- How to link table row content to source in Power View
- Stream Analytic to PowerBI complains about PowerBIOutputAdapterTransientError
- How can I connect datasets from machine learning to SQL database in Azure?
- drilling from powerbi to ssrs
- How do you connect an Azure Table Storage with Power BI through Stream Analytics?
Related Questions in PRIVATE
- Embedding Microsoft Power BI into Liferay
- PowerBI hierarchy creation without the cloud
- How to create nested tiles in Power View
- BI Designer many to many relationship
- Microsoft Power BI Designer data model to Excel or PowerPivot
- How to link table row content to source in Power View
- Stream Analytic to PowerBI complains about PowerBIOutputAdapterTransientError
- How can I connect datasets from machine learning to SQL database in Azure?
- drilling from powerbi to ssrs
- How do you connect an Azure Table Storage with Power BI through Stream Analytics?
Related Questions in ACCESS-LEVELS
- Embedding Microsoft Power BI into Liferay
- PowerBI hierarchy creation without the cloud
- How to create nested tiles in Power View
- BI Designer many to many relationship
- Microsoft Power BI Designer data model to Excel or PowerPivot
- How to link table row content to source in Power View
- Stream Analytic to PowerBI complains about PowerBIOutputAdapterTransientError
- How can I connect datasets from machine learning to SQL database in Azure?
- drilling from powerbi to ssrs
- How do you connect an Azure Table Storage with Power BI through Stream Analytics?
Related Questions in PACKAGE-PRIVATE
- Embedding Microsoft Power BI into Liferay
- PowerBI hierarchy creation without the cloud
- How to create nested tiles in Power View
- BI Designer many to many relationship
- Microsoft Power BI Designer data model to Excel or PowerPivot
- How to link table row content to source in Power View
- Stream Analytic to PowerBI complains about PowerBIOutputAdapterTransientError
- How can I connect datasets from machine learning to SQL database in Azure?
- drilling from powerbi to ssrs
- How do you connect an Azure Table Storage with Power BI through Stream Analytics?
Trending Questions
- UIImageView Frame Doesn't Reflect Constraints
- Is it possible to use adb commands to click on a view by finding its ID?
- How to create a new web character symbol recognizable by html/javascript?
- Why isn't my CSS3 animation smooth in Google Chrome (but very smooth on other browsers)?
- Heap Gives Page Fault
- Connect ffmpeg to Visual Studio 2008
- Both Object- and ValueAnimator jumps when Duration is set above API LvL 24
- How to avoid default initialization of objects in std::vector?
- second argument of the command line arguments in a format other than char** argv or char* argv[]
- How to improve efficiency of algorithm which generates next lexicographic permutation?
- Navigating to the another actvity app getting crash in android
- How to read the particular message format in android and store in sqlite database?
- Resetting inventory status after order is cancelled
- Efficiently compute powers of X in SSE/AVX
- Insert into an external database using ajax and php : POST 500 (Internal Server Error)
Popular # Hahtags
Popular Questions
- How do I undo the most recent local commits in Git?
- How can I remove a specific item from an array in JavaScript?
- How do I delete a Git branch locally and remotely?
- Find all files containing a specific text (string) on Linux?
- How do I revert a Git repository to a previous commit?
- How do I create an HTML button that acts like a link?
- How do I check out a remote Git branch?
- How do I force "git pull" to overwrite local files?
- How do I list all files of a directory?
- How to check whether a string contains a substring in JavaScript?
- How do I redirect to another webpage?
- How can I iterate over rows in a Pandas DataFrame?
- How do I convert a String to an int in Java?
- Does Python have a string 'contains' substring method?
- How do I check if a string contains a specific word?
I would not say that it is preferable.
Both practices are acceptable and don't shock me.
Now
private
should be favored as much as possible as it prevents undesirable coupling whilepackage-private
that creates a little more coupling should be used with relevancy.Even as you develop a library to be used by some clients, using the package modifier is not bad as the classes in the
package-private
doesn't make part directly of the API.Reversely, unit testing and
private
modifiers are not incompatible at all.I agree that using
package-private
modifier instead ofprivate
allows to test/mock/switch easily members of classes.In some cases, this practice is acceptable.
Now generalizing this is before all a design choice.
Personally I use the
package-private
modifier only as really relevant (a real issue for testing or a internal processing to share among other classes of the same package) because beyond making unit testing easier (which is a good point), I think that this kind of practice may favor a design that couples the classes more strongly than required.For example, suppose in a
B
class you may access a field/method of aA
class instance because these are in the same package.Suppose that conceptually this field make part of a very internal part of the
A
implementation and that it have not be known by other classes to allows to change it later.But as this field/method is package-private, now nothing prevents you from making it as you can.
I don't like that.
To finish, I would say that you should not worry about unit testing of
private
methods.Internals don't make part of the API. You don't need to test it.
Now if the private method is invoked multiple times or you really need to test this processing, nothing prevents you from extracting it in another class to make it testable and to have a way to mock the processing if required (to avoid test it multiple times).